User not logged in - login - register
Home Calendar Books School Tool Photo Gallery Message Boards Users Statistics Advertise Site Info
go to bottom | |
 Message Boards » » n00b SQL question Page [1]  
moron
All American
34185 Posts
user info
edit post

So this select query displays all the entries I want to see:

select *
FROM [crv].[dbo].[CRV_UsageLog]
INNER JOIN crv.dbo.CRV_Rooms
on CRV_UsageLog.RoomID=CRV_Rooms.RoomID
Inner JOIN crv.dbo.CRV_TreeRoomMap
on CRV_UsageLog.RoomID=CRV_TreeRoomMap.RoomID
where CRV_TreeRoomMap.TreeNodeID='dec8d04f-b01e-4c26-be8f-3e67f74414d6'
and CRV_UsageLog.Data2='Button Press'


How do I turn this into a delete statement, in MSSQL 2010?

Just changing to Select to a Delete doesn't work, changing it to a Delete * doesn't work. Based on googling I need to create a throwaway variable after the delete like

delete throwawayVariable
FROM [crv].[dbo].[CRV_UsageLog] throwawayVariable
INNER JOIN crv.dbo.CRV_Rooms
on CRV_UsageLog.RoomID=CRV_Rooms.RoomID
Inner JOIN crv.dbo.CRV_TreeRoomMap
on CRV_UsageLog.RoomID=CRV_TreeRoomMap.RoomID
where CRV_TreeRoomMap.TreeNodeID='dec8d04f-b01e-4c26-be8f-3e67f74414d6'
and CRV_UsageLog.Data2='Button Press'


Is that right? I don't want to accidentally delete my whole table...

11/26/2012 3:41:29 PM

disco_stu
All American
7436 Posts
user info
edit post

That should be fine. "Throwawayvariable" isn't really a throw away variable; it's a table alias. You're telling the query what side of the join you want the records deleted from.

(Edit: I'm not guaranteeing that your criteria syntax is correct and that you're not going to delete records you're not intending. use at your own risk. )

[Edited on November 26, 2012 at 3:47 PM. Reason : .]

11/26/2012 3:46:01 PM

synapse
play so hard
60940 Posts
user info
edit post

I would try something like this:

delete
from usagelog
where roomid in (
select usagelog.roomid
FROM [crv].[dbo].[CRV_UsageLog]
INNER JOIN crv.dbo.CRV_Rooms
on CRV_UsageLog.RoomID=CRV_Rooms.RoomID
Inner JOIN crv.dbo.CRV_TreeRoomMap
on CRV_UsageLog.RoomID=CRV_TreeRoomMap.RoomID
where CRV_TreeRoomMap.TreeNodeID='dec8d04f-b01e-4c26-be8f-3e67f74414d6'
and CRV_UsageLog.Data2='Button Press')


[Edited on November 26, 2012 at 3:53 PM. Reason : assuming you're trying to delete rows based on roomid, use at own risk ]

11/26/2012 3:46:36 PM

moron
All American
34185 Posts
user info
edit post

^^ I get this error, fyi:

Msg 4104, Level 16, State 1, Line 4
The multi-part identifier "CRV_UsageLog.RoomID" could not be bound.
Msg 4104, Level 16, State 1, Line 6
The multi-part identifier "CRV_UsageLog.RoomID" could not be bound.
Msg 4104, Level 16, State 1, Line 8
The multi-part identifier "CRV_UsageLog.Data2" could not be bound.


^ lemme try that...

11/26/2012 3:51:26 PM

disco_stu
All American
7436 Posts
user info
edit post

You're aliasing that table as "Throwawayvariable" in that query, try referencing them as such in the criteria as well.

11/26/2012 3:53:51 PM

moron
All American
34185 Posts
user info
edit post

yeah i just figured out...

I got this error now:


Msg 9002, Level 17, State 2, Line 1
The transaction log for database 'crv' is full due to 'LOG_BACKUP'.




I know there were 500,000 entries (of ~1,000,000) that needed to be deleted...

edit: okay, it still didn't delete anything, does it revert on errors??

[Edited on November 26, 2012 at 3:57 PM. Reason : ]

11/26/2012 3:55:28 PM

synapse
play so hard
60940 Posts
user info
edit post

Why would you set hard limits on your transaction log size? Pretty sure Autogrowth is enabled by default.

[Edited on November 26, 2012 at 4:01 PM. Reason : ]

11/26/2012 4:00:06 PM

moron
All American
34185 Posts
user info
edit post

The db was configured by a 3rd party vendor web app, i'm trying to do some maintenance that can't be done from the front end.

I'm not sure why they would set those limits too...

Also, the query you posted seems to select a lot more than I need it to (if I replace the delete with a select *).

11/26/2012 4:02:19 PM

synapse
play so hard
60940 Posts
user info
edit post

I was mainly posting that for structure and not logic. Get your logic right with a select, then instead of select * get only the primary key from the records to be deleted, then use that as a subquery like this:

delete
from table
where primary_key in(
select primary_key from ...)

11/26/2012 4:05:14 PM

moron
All American
34185 Posts
user info
edit post

gotcha, i'll still probably run into the transaction log size though right? I guess i need to solve that problem first...

11/26/2012 4:12:47 PM

synapse
play so hard
60940 Posts
user info
edit post

Do you have sysadmin permissions on the database?

11/26/2012 5:54:25 PM

moron
All American
34185 Posts
user info
edit post

Yep.

11/26/2012 8:26:52 PM

synapse
play so hard
60940 Posts
user info
edit post

I always mess with these settings via the GUI

http://www.simple-talk.com/sql/database-administration/sql-server-database-growth-and-autogrowth-settings/

11/27/2012 12:12:28 AM

Shaggy
All American
17820 Posts
user info
edit post

SELECT 
log.*
FROM
[crv].[dbo].[CRV_UsageLog] log
INNER JOIN crv.dbo.CRV_Rooms rooms
on log.RoomID=rooms.RoomID
INNER JOIN crv.dbo.CRV_TreeRoomMap trm
on log.RoomID=trm.RoomID
WHERE
trm.TreeNodeID='dec8d04f-b01e-4c26-be8f-3e67f74414d6'
AND log.Data2='Button Press'


should give you log rows you're trying to delete and

DELETE FROM
log
FROM
[crv].[dbo].[CRV_UsageLog] log
INNER JOIN crv.dbo.CRV_Rooms rooms
on log.RoomID=rooms.RoomID
INNER JOIN crv.dbo.CRV_TreeRoomMap trm
on log.RoomID=trm.RoomID
WHERE
trm.TreeNodeID='dec8d04f-b01e-4c26-be8f-3e67f74414d6'
AND log.Data2='Button Press'


should delete them. idk why you got those errors on the second query in ur top one cause it looks right.

maybe take a look at http://msdn.microsoft.com/en-us/library/ms189835.aspx#LimitRows if stuff still doesnt work? idk.

11/27/2012 12:46:29 AM

Shaggy
All American
17820 Posts
user info
edit post

also, who's been pressing buttons they shouldn't???

11/27/2012 12:47:35 AM

ndmetcal
All American
9012 Posts
user info
edit post

paging nOOb

11/27/2012 12:57:24 AM

Shaggy
All American
17820 Posts
user info
edit post

you should also always make sure you have a good backup before deleting data. tbh you really shouldnt ever delete data at all.

11/27/2012 10:07:50 AM

moron
All American
34185 Posts
user info
edit post

We have multiple layers of backups for this system, and it's not mission critical.

I'm still learning about this stuff (just for my own curiosity really-- it's not in my job description) and I don't want to be that guy that hoses something then have to run to the network admin to restore from the backup...

11/27/2012 1:10:27 PM

GenghisJohn
bonafide
10252 Posts
user info
edit post

be the fuck careful, especially since it isn't your job

12/1/2012 11:00:21 PM

 Message Boards » Tech Talk » n00b SQL question Page [1]  
go to top | |
Admin Options : move topic | lock topic

© 2024 by The Wolf Web - All Rights Reserved.
The material located at this site is not endorsed, sponsored or provided by or on behalf of North Carolina State University.
Powered by CrazyWeb v2.39 - our disclaimer.